Increase maximum number of modifiers in rcontrib

Mostapha · September 27, 2018, 12:16am

Hello everyone,

Currently the maximum number of modifiers in rcontrib is set to 10000. Is this because of some technical limitations? or can this be set to a higher number?

github.com

NREL/Radiance/blob/c1eb5f966e9a1683e0de0d39a2124a3f3136f7cc/src/rt/rcontrib.h#L91




#ifndef MAXPROCESS
#if defined(_WIN32) || defined(_WIN64)
#define MAXPROCESS	1
#else
#define MAXPROCESS	128
#endif
#endif


#ifndef	MAXMODLIST
#define	MAXMODLIST	10000		/* maximum modifiers we'll track */
#endif


extern const char	*modname[MAXMODLIST];	/* ordered modifier name list */
extern int		nmods;			/* number of modifiers */


extern char		RCCONTEXT[];		/* special evaluation context */


extern char		*formstr(int f);	/* return format identifier */


extern void		process_rcontrib(void);	/* trace ray contributions */

Greg_Ward · September 27, 2018, 6:43am

Anytime there is a constant bracketed by #ifdef’s like this, you can put “-DMAXMODLIST=20000” or similar in your rmake script or add it to the compile flags by other means to change the definition. In this case, there is just the memory cost of the modname[] array, and it was allocated this size because I don’t know of any systems that handle this many simultaneously open files. Of course, the number of modifier names doesn’t dictate the number of open files, but the two are usually related in rcontrib.