Possible bug in findglare/rtrace

radiance-dev
1

Hi,
I'm running into a strange issue when attempting to use findglare on Windows (built from source using MSVC 10 to compile).

findglare -v -ga 10-60:10 -t 0.000000 -r 250 -p image1.pic image1.oct >image1.glr
findglare: initializing data structures...
findglare: opening picture file "image1.pic"...

findglare: starting luminance calculation... rtrace -h- -ov -fff -ld- -i- -I- image1.oct
findglare: computing glare threshold...
rtrace: warning - no light sources found
findglare: threshold set to 1161.998064 cd/m2 from 1000 samples
findglare: analyzing... -3299313%

It starts at -3.8 million% & runs for quite a while.

If you want to test it out with my test image and octree you can download them from http://upload.iesve.com/downloads/radiance_issues/findglare_bug.zip

Any help would be most appreciated.

Palbinder Sandher
Software Platform Engineer
T: +44 (0) 141 945 8500
F: +44 (0) 141 945 8501
http://www.iesve.com

**Design, Simulate + Innovate with the <Virtual Environment>**
Integrated Environmental Solutions Limited. Registered in Scotland No. SC151456
Registered Office - Helix Building, West Of Scotland Science Park, Glasgow G20 0SP
Email Disclaimer

2

Hi Pally,

It seems tat you found an original bug in findglare. Frankly, I don't know why this hasn't caused problems before, because it is clearly an error that has been there from the beginning. Maybe compilers and systems have gotten better at array bounds checking? Anyway, I am attaching the corrected source file from ray/src/util/, which I'm hoping will fix the problem under Windows as well.

Cheers,
-Greg

glareval.c (10.1 KB)

3

Rebuilt findglare.exe with the supplied code change and I can confirm it now works perfectly.

Thanks for the extremely quick response Greg =)

[IES]<http://www.iesve.com/>

Palbinder Sandher
Software Platform Engineer

T:

+44 (0) 141 945 8500

F:

+44 (0) 141 945 8501

http://www.iesve.com<http://www.iesve.com/>

**Design, Simulate + Innovate with the <Virtual Environment>**

Integrated Environmental Solutions Limited. Registered in Scotland No. SC151456
Registered Office - Helix Building, West Of Scotland Science Park, Glasgow G20 0SP

Email Disclaimer<http://www.iesve.com/disclaimer.html>

ยทยทยท

From: Gregory J. Ward [mailto:[email protected]]
Sent: 10 October 2012 22:42
To: code development
Subject: Re: [Radiance-dev] Possible bug in findglare/rtrace

Hi Pally,

It seems tat you found an original bug in findglare. Frankly, I don't know why this hasn't caused problems before, because it is clearly an error that has been there from the beginning. Maybe compilers and systems have gotten better at array bounds checking? Anyway, I am attaching the corrected source file from ray/src/util/, which I'm hoping will fix the problem under Windows as well.

Cheers,
-Greg

From: Pally Sandher <[email protected]>
Date: October 10, 2012 11:18:59 AM GMT+02:00

Hi,
I'm running into a strange issue when attempting to use findglare on Windows (built from source using MSVC 10 to compile).

findglare -v -ga 10-60:10 -t 0.000000 -r 250 -p image1.pic image1.oct >image1.glr
findglare: initializing data structures...
findglare: opening picture file "image1.pic"...

findglare: starting luminance calculation... rtrace -h- -ov -fff -ld- -i- -I- image1.oct
findglare: computing glare threshold...
rtrace: warning - no light sources found
findglare: threshold set to 1161.998064 cd/m2 from 1000 samples
findglare: analyzing... -3299313%

It starts at -3.8 million% & runs for quite a while.

If you want to test it out with my test image and octree you can download them from http://upload.iesve.com/downloads/radiance_issues/findglare_bug.zip

Any help would be most appreciated.

Palbinder Sandher
Software Platform Engineer
T: +44 (0) 141 945 8500
F: +44 (0) 141 945 8501
http://www.iesve.com

_______________________________________________
Radiance-dev mailing list
[email protected]
http://www.radiance-online.org/mailman/listinfo/radiance-dev