new evalglare version available

Hi All,

I want to announce a new evalglare version ready for download. (version 1.0).

Following main changes are included (see also the short documentation which is included in the package) :

-all current view types will be supported (except parallel view) - that means also -vth !
-valid view is checked (many problems occurred, because often users treat the image with programs like pcompos before putting into evalglare. But then, the view got lost and a wrong view leads to totally wrong results! Now this will be handled by the new evalglare )
-view options can be provided also per command line option
-disability glare is also calculated
-cut-out the "Guth" visual field
-extension of the DGP equation for low-brightness scenes (Ev<380lux) , based on new user assessments

The main routines for glare source detection and calculation of the glare values are not changed.

Anyhow I strongly recommend to use from now on only the new version, because the issue with non valid views can cause many troubles and wrong values.
(and I guess many people use it and run into that problem and got wrong values without knowing it!!).

You can download the new version here:

http://www.ise.fraunhofer.de/radiance

good luck and an always glare free environment... ,

Jan

···

--
Dr.-Ing. Jan Wienold
Head of Team Passive Systems and Daylighting
Fraunhofer-Institut für Solare Energiesysteme
Thermal Systems and Buildings
Heidenhofstr. 2, 79110 Freiburg, Germany
Phone: +49(0)761 4588 5133 Fax:+49(0)761 4588 9133
[email protected]

In office:
Mo,Tue: 8:30-18:00
We,Thu: 8:30-16:00
Fr: 8:30-15:30

Hi Jan,

Exciting news!

I just tried compiling this on MacOS ang I get the following error:

rgugliel-14846s:evalglare rgugliel$ make evalglare
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/color.o common/color.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/resolu.o common/resolu.c -I. -Igeometry
common/resolu.c: In function Œstr2resolu¹:
common/resolu.c:98: warning: implicit declaration of function Œatoi¹
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/header.o common/header.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/image.o common/image.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/fvect.o common/fvect.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/badarg.o common/badarg.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/words.o common/words.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/fputword.o common/fputword.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/expandarg.o common/expandarg.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/wordfile.o common/wordfile.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/bmalloc.o common/bmalloc.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/mat4.o common/mat4.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o pictool.o
pictool.c -I. -Igeometry
pictool.c: In function Œread_exposure¹:
pictool.c:90: error: nested functions are disabled, use -fnested-functions
to re-enable
make: *** [pictool.o] Error 1

Then I tried the following, also with no luck:

rgugliel-14846s:evalglare rgugliel$ make evalglare -fnested-functions
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$ make -fnested-functions evalglare
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$

Ideas? I know you only vouch for Linux with the source and provide a
pre-compiled Windows version, but it'd be good to get this working on
MacOS once and for all, now that it's at version 1.0 status.

Rob Guglielmetti IESNA, LEED AP
Commercial Buildings Research Group
National Renewable Energy Laboratory
1617 Cole Blvd MS:RSF202
Golden, CO 80401
T. 303.275.4319
F. 303.630.2055
E. [email protected]

···

On 2/17/12 6:59 AM, "Jan Wienold" <[email protected]> wrote:

Hi All,

I want to announce a new evalglare version ready for download. (version
1.0).

Following main changes are included (see also the short documentation
which is included in the package) :

-all current view types will be supported (except parallel view) - that
means also -vth !
-valid view is checked (many problems occurred, because often users
treat the image with programs like pcompos before putting into
evalglare. But then, the view got lost and a wrong view leads to totally
wrong results! Now this will be handled by the new evalglare )
-view options can be provided also per command line option
-disability glare is also calculated
-cut-out the "Guth" visual field
-extension of the DGP equation for low-brightness scenes (Ev<380lux) ,
based on new user assessments

The main routines for glare source detection and calculation of the
glare values are not changed.

Anyhow I strongly recommend to use from now on only the new version,
because the issue with non valid views can cause many troubles and wrong
values.
(and I guess many people use it and run into that problem and got wrong
values without knowing it!!).

You can download the new version here:

http://www.ise.fraunhofer.de/radiance

good luck and an always glare free environment... ,

Jan

--
Dr.-Ing. Jan Wienold
Head of Team Passive Systems and Daylighting
Fraunhofer-Institut für Solare Energiesysteme
Thermal Systems and Buildings
Heidenhofstr. 2, 79110 Freiburg, Germany
Phone: +49(0)761 4588 5133 Fax:+49(0)761 4588 9133
[email protected]
http://www.ise.fraunhofer.de

In office:
Mo,Tue: 8:30-18:00
We,Thu: 8:30-16:00
Fr: 8:30-15:30

_______________________________________________
Radiance-general mailing list
[email protected]
http://www.radiance-online.org/mailman/listinfo/radiance-general

Rob

The -fnested-functions options should go into the GCC arguments. I think
make has it's own way of handling "-f" options so it won't pass this on to
the compiler.

Regards,
Thomas

···

On Fri, Feb 17, 2012 at 11:34 AM, Guglielmetti, Robert < [email protected]> wrote:

pictool.c: In function Œread_exposure¹:
pictool.c:90: error: nested functions are disabled, use -fnested-functions
to re-enable
make: *** [pictool.o] Error 1

Then I tried the following, also with no luck:

rgugliel-14846s:evalglare rgugliel$ make evalglare -fnested-functions
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$ make -fnested-functions evalglare
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$

Ideas? I know you only vouch for Linux with the source and provide a
pre-compiled Windows version, but it'd be good to get this working on
MacOS once and for all, now that it's at version 1.0 status.

Thanks Thomas,

I added that flag to the makefile, and the code built, but I get "Abort Trap" errors when I try to use evalglare on MacOS (which is the error I used to get with the old version). Has anyone been able to get a usable build of evalglare on MacOS?

Rob Guglielmetti IESNA, LEED AP
Commercial Buildings Research Group
National Renewable Energy Laboratory
1617 Cole Blvd MS:RSF202
Golden, CO 80401
T. 303.275.4319
F. 303.630.2055
E. [email protected]

···

On 2/17/12 11:05 AM, "Thomas Bleicher" <[email protected]<mailto:[email protected]>> wrote:

Rob

The -fnested-functions options should go into the GCC arguments. I think make has it's own way of handling "-f" options so it won't pass this on to the compiler.

Regards,
Thomas

On Fri, Feb 17, 2012 at 11:34 AM, Guglielmetti, Robert <[email protected]<mailto:[email protected]>> wrote:
pictool.c: In function Œread_exposure¹:
pictool.c:90: error: nested functions are disabled, use -fnested-functions
to re-enable
make: *** [pictool.o] Error 1

Then I tried the following, also with no luck:

rgugliel-14846s:evalglare rgugliel$ make evalglare -fnested-functions
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$ make -fnested-functions evalglare
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$

Ideas? I know you only vouch for Linux with the source and provide a
pre-compiled Windows version, but it'd be good to get this working on
MacOS once and for all, now that it's at version 1.0 status.

Jan,

Another error report here. I use linux (gcc version 4.5.2 (Ubuntu/Linaro 4.5.2-8ubuntu4).

I have the following warning when compiling:

···

*********************
In function ‘strcpy’,
     inlined from ‘main’ at evalglare.c:1194:8:
/usr/include/bits/string3.h:105:3: warning: call to __builtin___strcpy_chk will always overflow destination buffer
*********************

evalglare is produced despite the warning. But when I tried to use it, I have the following error:
*********************
*** buffer overflow detected ***: evalglare terminated
======= Backtrace: =========
/lib/i386-linux-gnu/libc.so.6(__fortify_fail+0x50)[0xb7647df0]
/lib/i386-linux-gnu/libc.so.6(+0xe4cca)[0xb7646cca]
/lib/i386-linux-gnu/libc.so.6(__strcpy_chk+0x3f)[0xb764605f]
evalglare[0x804b9c5]
/lib/i386-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0xb7578e37]
evalglare[0x80490f1]
*********************

Any idea why?

Thanks,

Ery

On 02/17/2012 09:34 AM, Guglielmetti, Robert wrote:

Hi Jan,

Exciting news!

I just tried compiling this on MacOS ang I get the following error:

rgugliel-14846s:evalglare rgugliel$ make evalglare
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/color.o common/color.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/resolu.o common/resolu.c -I. -Igeometry
common/resolu.c: In function Œstr2resolu¹:
common/resolu.c:98: warning: implicit declaration of function Œatoi¹
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/header.o common/header.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/image.o common/image.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/fvect.o common/fvect.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/badarg.o common/badarg.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/words.o common/words.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/fputword.o common/fputword.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/expandarg.o common/expandarg.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/wordfile.o common/wordfile.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/bmalloc.o common/bmalloc.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/mat4.o common/mat4.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o pictool.o
pictool.c -I. -Igeometry
pictool.c: In function Œread_exposure¹:
pictool.c:90: error: nested functions are disabled, use -fnested-functions
to re-enable
make: *** [pictool.o] Error 1

Then I tried the following, also with no luck:

rgugliel-14846s:evalglare rgugliel$ make evalglare -fnested-functions
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$ make -fnested-functions evalglare
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$

Ideas? I know you only vouch for Linux with the source and provide a
pre-compiled Windows version, but it'd be good to get this working on
MacOS once and for all, now that it's at version 1.0 status.

Rob Guglielmetti IESNA, LEED AP
Commercial Buildings Research Group
National Renewable Energy Laboratory
1617 Cole Blvd MS:RSF202
Golden, CO 80401
T. 303.275.4319
F. 303.630.2055
E. [email protected]

On 2/17/12 6:59 AM, "Jan Wienold"<[email protected]> wrote:

Hi All,

I want to announce a new evalglare version ready for download. (version
1.0).

Following main changes are included (see also the short documentation
which is included in the package) :

-all current view types will be supported (except parallel view) - that
means also -vth !
-valid view is checked (many problems occurred, because often users
treat the image with programs like pcompos before putting into
evalglare. But then, the view got lost and a wrong view leads to totally
wrong results! Now this will be handled by the new evalglare )
-view options can be provided also per command line option
-disability glare is also calculated
-cut-out the "Guth" visual field
-extension of the DGP equation for low-brightness scenes (Ev<380lux) ,
based on new user assessments

The main routines for glare source detection and calculation of the
glare values are not changed.

Anyhow I strongly recommend to use from now on only the new version,
because the issue with non valid views can cause many troubles and wrong
values.
(and I guess many people use it and run into that problem and got wrong
values without knowing it!!).

You can download the new version here:

http://www.ise.fraunhofer.de/radiance

good luck and an always glare free environment... ,

Jan

--
Dr.-Ing. Jan Wienold
Head of Team Passive Systems and Daylighting
Fraunhofer-Institut für Solare Energiesysteme
Thermal Systems and Buildings
Heidenhofstr. 2, 79110 Freiburg, Germany
Phone: +49(0)761 4588 5133 Fax:+49(0)761 4588 9133
[email protected]
http://www.ise.fraunhofer.de

In office:
Mo,Tue: 8:30-18:00
We,Thu: 8:30-16:00
Fr: 8:30-15:30

_______________________________________________
Radiance-general mailing list
[email protected]
http://www.radiance-online.org/mailman/listinfo/radiance-general

_______________________________________________
Radiance-general mailing list
[email protected]
http://www.radiance-online.org/mailman/listinfo/radiance-general

Jan, Rob,

I don't think nested functions are any version of standard C; I'm pretty sure they are a GNU compiler extension. If it's possible, do you think you could engineer these out? I'd look at it, but no-way do I have time to work on it.

it's probably best if C code compiles with the gcc "-ansi -pedantic" (c90) or "-std=c99 -pedantic" options. That's not a complete check; some non-ISO usages are not caught, but it's better than simply letting something completely non-standard slip through.

Randolph

(Do we need to take this to the developer list?)

···

On 2012-02-17 16:34:39 +0000, Guglielmetti, Robert said:

Hi Jan,

Exciting news!

I just tried compiling this on MacOS ang I get the following error:

rgugliel-14846s:evalglare rgugliel$ make evalglare
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/color.o common/color.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/resolu.o common/resolu.c -I. -Igeometry
common/resolu.c: In function Œstr2resolu¹:
common/resolu.c:98: warning: implicit declaration of function Œatoi¹
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/header.o common/header.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/image.o common/image.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/fvect.o common/fvect.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/badarg.o common/badarg.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/words.o common/words.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/fputword.o common/fputword.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/expandarg.o common/expandarg.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/wordfile.o common/wordfile.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/bmalloc.o common/bmalloc.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/mat4.o common/mat4.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o pictool.o
pictool.c -I. -Igeometry
pictool.c: In function Œread_exposure¹:
pictool.c:90: error: nested functions are disabled, use -fnested-functions
to re-enable
make: *** [pictool.o] Error 1

Then I tried the following, also with no luck:

rgugliel-14846s:evalglare rgugliel$ make evalglare -fnested-functions
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$ make -fnested-functions evalglare
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$

Ideas? I know you only vouch for Linux with the source and provide a
pre-compiled Windows version, but it'd be good to get this working on
MacOS once and for all, now that it's at version 1.0 status.

Rob Guglielmetti IESNA, LEED AP
Commercial Buildings Research Group
National Renewable Energy Laboratory
1617 Cole Blvd MS:RSF202
Golden, CO 80401
T. 303.275.4319
F. 303.630.2055
E. [email protected]

On 2/17/12 6:59 AM, "Jan Wienold" > <[email protected]> wrote:

Hi All,

I want to announce a new evalglare version ready for download. (version
1.0).

Following main changes are included (see also the short documentation
which is included in the package) :

-all current view types will be supported (except parallel view) - that
means also -vth !
-valid view is checked (many problems occurred, because often users
treat the image with programs like pcompos before putting into
evalglare. But then, the view got lost and a wrong view leads to totally
wrong results! Now this will be handled by the new evalglare )
-view options can be provided also per command line option
-disability glare is also calculated
-cut-out the "Guth" visual field
-extension of the DGP equation for low-brightness scenes (Ev<380lux) ,
based on new user assessments

The main routines for glare source detection and calculation of the
glare values are not changed.

Anyhow I strongly recommend to use from now on only the new version,
because the issue with non valid views can cause many troubles and wrong
values.
(and I guess many people use it and run into that problem and got wrong
values without knowing it!!).

You can download the new version here:

http://www.ise.fraunhofer.de/radiance

good luck and an always glare free environment... ,

Jan

--
Dr.-Ing. Jan Wienold
Head of Team Passive Systems and Daylighting
Fraunhofer-Institut für Solare Energiesysteme
Thermal Systems and Buildings
Heidenhofstr. 2, 79110 Freiburg, Germany
Phone: +49(0)761 4588 5133 Fax:+49(0)761 4588 9133
[email protected]
http://www.ise.fraunhofer.de

In office:
Mo,Tue: 8:30-18:00
We,Thu: 8:30-16:00
Fr: 8:30-15:30

_______________________________________________
Radiance-general mailing list
[email protected]
http://www.radiance-online.org/mailman/listinfo/radiance-general

--
Randolph M. Fritz

Hi all,

oh dear, I thought there is no problem compiling it, since I got it easily under my opensuse12.1, debian lenny, cygwin and mingw running...

Unfortunately I will be away the next days and cannot work on the code - also my collegue who implemented the new check regarding view options is on vacation next week. So we will look at it the week after - sorry for any inconvenience! As soon as he is back, we will look at this and provide a new version.

Jan

···

On 02/17/2012 09:16 PM, Randolph M. Fritz wrote:

Jan, Rob,

I don't think nested functions are any version of standard C; I'm pretty sure they are a GNU compiler extension. If it's possible, do you think you could engineer these out? I'd look at it, but no-way do I have time to work on it.

it's probably best if C code compiles with the gcc "-ansi -pedantic" (c90) or "-std=c99 -pedantic" options. That's not a complete check; some non-ISO usages are not caught, but it's better than simply letting something completely non-standard slip through.

Randolph

(Do we need to take this to the developer list?)

On 2012-02-17 16:34:39 +0000, Guglielmetti, Robert said:

Hi Jan,

Exciting news!

I just tried compiling this on MacOS ang I get the following error:

rgugliel-14846s:evalglare rgugliel$ make evalglare
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/color.o common/color.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/resolu.o common/resolu.c -I. -Igeometry
common/resolu.c: In function Œstr2resolu¹:
common/resolu.c:98: warning: implicit declaration of function Œatoi¹
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/header.o common/header.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/image.o common/image.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/fvect.o common/fvect.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/badarg.o common/badarg.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/words.o common/words.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/fputword.o common/fputword.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/expandarg.o common/expandarg.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/wordfile.o common/wordfile.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/bmalloc.o common/bmalloc.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o
common/mat4.o common/mat4.c -I. -Igeometry
gcc -c -g -DMSDOS -DPICT_GLARE -DFLOAT=double -O3 -Wall -o pictool.o
pictool.c -I. -Igeometry
pictool.c: In function Œread_exposure¹:
pictool.c:90: error: nested functions are disabled, use -fnested-functions
to re-enable
make: *** [pictool.o] Error 1

Then I tried the following, also with no luck:

rgugliel-14846s:evalglare rgugliel$ make evalglare -fnested-functions
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$ make -fnested-functions evalglare
make: nested-functions: No such file or directory
make: *** No rule to make target `nested-functions'. Stop.
rgugliel-14846s:evalglare rgugliel$

Ideas? I know you only vouch for Linux with the source and provide a
pre-compiled Windows version, but it'd be good to get this working on
MacOS once and for all, now that it's at version 1.0 status.

Rob Guglielmetti IESNA, LEED AP
Commercial Buildings Research Group
National Renewable Energy Laboratory
1617 Cole Blvd MS:RSF202
Golden, CO 80401
T. 303.275.4319
F. 303.630.2055
E. [email protected]

On 2/17/12 6:59 AM, "Jan Wienold" <[email protected]> wrote:

Hi All,

I want to announce a new evalglare version ready for download. (version
1.0).

Following main changes are included (see also the short documentation
which is included in the package) :

-all current view types will be supported (except parallel view) - that
means also -vth !
-valid view is checked (many problems occurred, because often users
treat the image with programs like pcompos before putting into
evalglare. But then, the view got lost and a wrong view leads to totally
wrong results! Now this will be handled by the new evalglare )
-view options can be provided also per command line option
-disability glare is also calculated
-cut-out the "Guth" visual field
-extension of the DGP equation for low-brightness scenes (Ev<380lux) ,
based on new user assessments

The main routines for glare source detection and calculation of the
glare values are not changed.

Anyhow I strongly recommend to use from now on only the new version,
because the issue with non valid views can cause many troubles and wrong
values.
(and I guess many people use it and run into that problem and got wrong
values without knowing it!!).

You can download the new version here:

http://www.ise.fraunhofer.de/radiance

good luck and an always glare free environment... ,

Jan

--
Dr.-Ing. Jan Wienold
Head of Team Passive Systems and Daylighting
Fraunhofer-Institut für Solare Energiesysteme
Thermal Systems and Buildings
Heidenhofstr. 2, 79110 Freiburg, Germany
Phone: +49(0)761 4588 5133 Fax:+49(0)761 4588 9133
[email protected]
http://www.ise.fraunhofer.de

In office:
Mo,Tue: 8:30-18:00
We,Thu: 8:30-16:00
Fr: 8:30-15:30

_______________________________________________
Radiance-general mailing list
[email protected]
http://www.radiance-online.org/mailman/listinfo/radiance-general

--
Dr.-Ing. Jan Wienold
Head of Team Passive Systems and Daylighting
Fraunhofer-Institut für Solare Energiesysteme
Thermal Systems and Buildings
Heidenhofstr. 2, 79110 Freiburg, Germany
Phone: +49(0)761 4588 5133 Fax:+49(0)761 4588 9133
[email protected]

In office:
Mo,Tue: 8:30-18:00
We,Thu: 8:30-16:00
Fr: 8:30-15:30

Hi!

First of all, thank you Jan for providing us with an improved release of
evalglare!

I have the following warning when compiling:
*********************
In function ‘strcpy’,
    inlined from ‘main’ at evalglare.c:1194:8:
/usr/include/bits/string3.h:105:3: warning: call to
__builtin___strcpy_chk will always overflow destination buffer
*********************

Hm, honestly evalglare contains quite a lot of code handling strings in
a rather risky way. E.g. the mentioned warning results from using strcpy
without checking that enough memory is available for the version string
- which results in compiler warnings (the best thing to happen) or
crashes. In this specific case, you can simply reserve some more memory
for the version string changing the line 1149 from

char file_out[500], file_out2[500], blank[1], version[40];

to

char file_out[500], file_out2[500], blank[1], version[64];

But of course the next change in the version string may break this
again. It would probably make a lot of sense to use defines for the
string operations (the whole version variable is not really needed
here), or at least set a variable to the maximum string length (Radiance
has MAXSTR) and check that what you copy into a string never exceeds
this (using strlen).

Cheers, Lars.

Hi!

First of all, thank you Jan for providing us with an improved release of
evalglare!

Indeed, thanks Jan!

Hm, honestly evalglare contains quite a lot of code handling strings in
a rather risky way. E.g. the mentioned warning results from using strcpy
without checking that enough memory is available for the version string<snip>

THanks Lars for providing this advice. Looking forward to seeing what Jan comes up with upon his return!

- Rob

···

On Feb 18, 2012, at 3:45 AM, Lars O. Grobe wrote:

Dear Jan,

I tried as well to run evalglare on Mac OS 10.6.8 and had the same problem posted by Robert.
Was there any development about this?

Thanks, Stefano

···

--

Stefano Moret
California Lighting Technology Center<http://cltc.ucdavis.edu/>
University of California, Davis
633 Pena Drive
Davis, CA 95618

[email protected]<mailto:[email protected]>